Talk:Import/Franklin County, Ohio Buildings
Geometry
Many buildings have curves which are approximated by a high concentration for nodes. I believe that this is fairly serious and should be corrected.
See: https://wiki.openstreetmap.org/wiki/Import/Guidelines#Consider_simplifying
- - - The source data has already been generalized at a one foot tolerance to remove any duplicate vertices which have proved problematic in OSM. We will review methods to detect and reduce the number of vertices in curves while still maintaining reasonable shape and not negatively impacting other geometry. --Jshimota (talk) 21:42, 7 August 2020 (UTC)
Pitch/Buildings
I'm a little suspicious of the { building=yes, leasure=pitch } combination. I would check to verify that these are actually buildings.
- - - Good catch on leisure=pitch. They were all tennis courts and sports fields and have been omitted from the data. --Jshimota (talk) 21:43, 7 August 2020 (UTC)
Names
You have many highly duplicated names. Things like "Tunnel", "Dam", "Dock", "Fire Dept" aren't names, but should be translated to more appropriate tags. - - - The values have been reviewed and a few dozen generic text strings removed including those above. Also corrected several obvious typos and punctuation errors. --Jshimota (talk) 21:44, 7 August 2020 (UTC)
Shape__Length & Shape__Area
Are these tags going to be imported into OSM? I don't see any documentation describing how these tags are used.
Blackboxlogic (talk) 15:47, 31 July 2020 (UTC)
---
@Blackboxlogic Thanks for the detailed review and feedback! We will take a look at each of these and make appropriate updates.
With regard to the Shape_Length and Shape_Area, those fields will not be used for tags. They are required fields for the geometry but should not be exposed through the OSM Editor tools that access this layer, nor should they appear in the popup for the live feature layer. The only tags that should be used for this layer are building, name, and leisure. --Dkensok (talk) 16:30, 31 July 2020 (UTC)